Made Daily Scoreboard show only Daily scores#26
Made Daily Scoreboard show only Daily scores#26Hipposgrumm wants to merge 8 commits intoSoDOff-Project:masterfrom
Conversation
|
Why do we need two new tables for data that's already in the database? |
|
The data only contains the latest and highest score. There is no way to get the highest score gotten today with the current way it is set up. For example, Player1 scores 3000 points on the first day. That score is added to the leaderboard and shown as their score for today. The next day, they score 2000 points. |
|
Actually. I just thought of a way to optimize it to add one column instead of two tables. |
|
I have optimized the code. |
|
I have fixed any existing merge conflicts and am still waiting for this to be re-reviewed. |
|
Why can't we use |
IIRC (it's been a while since looking at the code) |
|
It returns e.Value instead of e.DailyValue, but it can be modified to return e.DailyValue for this use case... |
|
I just realized that's probably not the best name for a commit. |
|
Just wondering can you look at this again? |
This makes
ContentWebService.asmx/GetPeriodicGameDataByGameactually return the top scores associated with Today.Previous behavior was getting the top score based on the most recent scores submitted in the past 24 hours. This meant that the score shown was the best all-time score, not the best today score.
Additionally, this change associates each score with a date, so yesterday's scores don't overlap with today's. (This is all subjective to the timezone of the server.)
The following SQL commands are required with the update: